(XS) RFR: 8077674: BSD build failures due to undefined macros
Dmitry Samersoff
dmitry.samersoff at oracle.com
Tue Apr 14 11:25:48 UTC 2015
David,
It's better to change
#ifdef __APPLE__
to
#if defined(__APPLE__)
-Dmitry
On 2015-04-14 13:20, David Holmes wrote:
> webrev:
>
> http://cr.openjdk.java.net/~dholmes/8077674/webrev/
>
> From the original error report:
>> "-Wundef option causes GCC to warn whenever it encounters an identifier
>> which is not a macro in an ‘#if’. "
>>
>> Hence we should be using
>>
>> #elif defined(__FreeBSD__)
>>
>> etc in this context.
>
> I also founds similar suspect usages in os_linux.cpp and os_windows.cpp.
>
> Thanks,
> David
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
More information about the hotspot-runtime-dev
mailing list