(XS) RFR: 8077674: BSD build failures due to undefined macros

[David Holmes]

Hi Dmitry,

On 14/04/2015 9:25 PM, Dmitry Samersoff wrote:
> David,
>
> It's better to change
>
> #ifdef __APPLE__
>
> to
>
> #if defined(__APPLE__)

Why? They seem 100% equivalent. Plus that would mean a lot of changes. 
Plus we use that pattern in many, many, many places.

Thanks,
David

> -Dmitry
>
>
> On 2015-04-14 13:20, David Holmes wrote:
>> webrev:
>>
>> http://cr.openjdk.java.net/~dholmes/8077674/webrev/
>>
>>  From the original error report:
>>> "-Wundef option causes GCC to warn whenever it encounters an identifier
>>> which is not a macro in an ‘#if’. "
>>>
>>> Hence we should be using
>>>
>>> #elif defined(__FreeBSD__)
>>>
>>> etc in this context.
>>
>> I also founds similar suspect usages in os_linux.cpp and os_windows.cpp.
>>
>> Thanks,
>> David
>
>