RFR: 8049632: JDK 1.8.0 b132 :Linux x64 : Crash in ClassFileParser::copy_localvariable_table(..)

[serguei.spitsyn at oracle.com]

Coleen,

The fix looks good.
It is great, you added new tests for it, thanks!

I have one question about the tests though.
It seems there are no duplicated LVT/LVTT in the tests *DuplicateLVT.cod,
**DuplicateLVTT.cod* and *NotFoundLVTT.cod* has LVTT.

Do I miss anything?

Thanks,
Serguei


On 1/28/15 8:11 AM, Coleen Phillimore wrote:
> Summary: Use resource allocated hashtable for local variable table 
> checking
>
> I was never able to reproduce this after considerable time trying. I 
> also never found anything wrong with the code that would cause an 
> extra or incorrect os::free call.  This change checks LVT entries 
> using the existing ResourceHashtable rather than a ad-hoc extra 
> hashtable definition in classFileParser.cpp.  So this change removes 
> the os::free call.  I think whatever caused the original bug will 
> crash somewhere else now, and hopefully be easier to find.
>
> Tested with jck9, jck1.4 runThese tests, nsk and jtreg tests, and 
> added test.
>
> open webrev at http://cr.openjdk.java.net/~coleenp/8049632/
> bug link https://bugs.openjdk.java.net/browse/JDK-8049632
>
> Thanks,
> Coleen
>