RFR(XS) 8130183: InnerClasses: VM permits wrong inner_class_info_index value of zero

Karen Kinnear karen.kinnear at oracle.com
Wed Jul 8 16:07:29 UTC 2015


Harold,

The code looks good.

Does this also catch the anonymous/local class with zero inner_class_info_index - i.e. did you run the other examples attached to the bug?

thanks,
Karen

On Jul 8, 2015, at 8:16 AM, harold seigel wrote:

> Hi,
> 
> Please review this small change to fix bug JDK-8130183.  The JVM allows the InnerClasses attributes inner_class_info_index to have the value of zero.  This violates JVM-Spec 8.  See http://docs.oracle.com/javase/specs/jvms/se8/html/jvms-4.html#jvms-4.7.6.
> 
> The fix ensures that the inner_class_info_index is non-zero and is a valid index into the constant pool.
> 
> Open Webrev: http://cr.openjdk.java.net/~hseigel/bug_8130183/
> 
> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8130183
> 
> The fix was tested with JCL Lang and VM tests, the UTE quick and split_verifier tests, and the hotspot, java/io, java/lang, and java/util JTreg tests.
> 
> Thanks, Harold



More information about the hotspot-runtime-dev mailing list