Open code review for 8061999 Enhance VM option parsing to allow options to be specified

[Daniel D. Daugherty]

Dimitry is correct that the current limitations on the options file
implementation are based on the previous limitations on the options
environment variables. We did track the fix for JDK-8074895 as it
made its way into the system, but we made the choice to not change
the options file implementation at this time in order to reduce the
risk to this rather large change.

In the "Future Work" section of Ron's soon to be posted document,
there are entries for removing both the 1024 byte limit and the 64
option limit.

Dan



On 7/9/15 5:14 AM, David Holmes wrote:
> On 9/07/2015 8:55 PM, Dmitry Dmitriev wrote:
>> Hello David,
>>
>> I think that it look like same limitations which was applied to the
>> options in environment variables before JDK-8074895
>> <https://bugs.openjdk.java.net/browse/JDK-8074895> fix. I think Ron can
>> add more information about that.
>
> You can't read an environment variable line-by-line so we have to have 
> fixed buffer. A file can be read line-by-line.
>
> Cheers,
> David
>
>> Thanks,
>> Dmitry
>>
>> On 09.07.2015 8:06, David Holmes wrote:
>>> <trimming>
>>>
>>> On 9/07/2015 6:29 AM, Dmitry Dmitriev wrote:
>>>> On 08.07.2015 22:26, Karen Kinnear wrote:
>>>>> 2) is there a maximum length to the options read in from the file?
>>>> The current implemented limitations are following: only one VM option
>>>> file can be specified, maximum size of the file is 1024 bytes, up 
>>>> to 64
>>>> VM options
>>>
>>> That seems extremely limiting. Why should there be a maximum size, why
>>> can't you just read the file line by line and keep processing until it
>>> is all read ??
>>>
>>> Thanks,
>>> David
>>