RFR: 8158854: Ensure release_store is paired with load_acquire in lock-free code

David Holmes david.holmes at oracle.com
Fri Aug 19 01:09:46 UTC 2016


On 19/08/2016 12:15 AM, Aleksey Shipilev wrote:
> On 08/18/2016 05:50 AM, David Holmes wrote:
>> webrev: http://cr.openjdk.java.net/~dholmes/8158854/webrev/
>
> Looks good to me. Minor nit:

Thanks for the review Aleksey!

> *) inline declarations have different indenting, is that our code style?

No it's my dumb emacs that insists on tabbing to 4 instead of 2 when I'm 
not looking :)

Indent fixed there and elsewhere. webrev updated in place for others.

Thanks,
David


> 370   Klass* array_klasses() const             { return _array_klasses; }
>  371     inline Klass* array_klasses_acquire() const; // load with
> acquire semantics
>  372   void set_array_klasses(Klass* k)         { _array_klasses = k; }
>  373     inline void release_set_array_klasses(Klass* k); // store with
> release semantics
>
> Thanks,
> -Aleksey
>


More information about the hotspot-runtime-dev mailing list