RFR(S): 8163146 - Remove os::check_heap on Windows

[Christian Tornqvist]

Hi Thomas,

 

Yes, we’ve seen a lot of false positives. 

 

Thanks,

Christian

 

From: Thomas Stüfe [mailto:thomas.stuefe at gmail.com] 
Sent: Wednesday, August 24, 2016 2:33 AM
To: Christian Tornqvist <christian.tornqvist at oracle.com>
Cc: hotspot-runtime-dev <hotspot-runtime-dev at openjdk.java.net>
Subject: Re: RFR(S): 8163146 - Remove os::check_heap on Windows

 

Hi Christian,

 

this looks fine.

 

Out of curiosity, what were the issues? Did you get false positives or did HeapValidate not find anything?

 

Kind Regards, Thomas

 

On Tue, Aug 23, 2016 at 11:54 PM, Christian Tornqvist <christian.tornqvist at oracle.com <mailto:christian.tornqvist at oracle.com> > wrote:

Hi everyone,



Please review this small change that removes os::check_heap, it's proven to
be unreliable. The same functionality and more can be enabled in Windows
using gflags (pageheap) or by turning on heap debugging in Windbg using the
!heap extension.



Tested by running hotspot_fast_runtime test group on all platforms.



Webrev:

http://cr.openjdk.java.net/~ctornqvi/webrev/8163146/webrev.00/



Bug:

https://bugs.openjdk.java.net/browse/JDK-8163146



Thanks,

Christian