RFR(S): 8162412: Ignore any System property specified as -Djdk.module...

[Gerard Ziemski]

hi Harold,

The code looks fine, I just have a question and tiny quibble:

#1. This comment:

 189 // Return true if property starts with "jdk.module." and its ensuing chars match
 190 // any of the reserved module properties.
 191 // property should be passed without the leading "-D".
 192 bool Arguments::is_internal_module_property(const char* property) {

about “-D” refers to the property expected by "Arguments::is_internal_module_property” method, not how the user passes it to the VM?


#2. The only tiny quibble would be to put:

200         matches_property_suffix(property_suffix, PATCH, PATCH_LEN) ||

right after

197         matches_property_suffix(property_suffix, ADDREADS, ADDREADS_LEN) ||

to match their declaration order:

170 #define ADDREADS "addreads"
171 #define ADDREADS_LEN 8
172 #define PATCH "patch"
173 #define PATCH_LEN 5


cheers

> On Aug 30, 2016, at 12:47 PM, harold seigel <harold.seigel at oracle.com> wrote:
> 
> Hi,
> 
> Please review this fix for JDK-8162412.  This fix allows user properties that start with "-Djdk.module." unless they match any of the seven reserved system properties as  follows:
> 
>   The JVM will ignore -D<property>, -D<property>.[*], and
>   -D<property>=[*] where <property> is any one of these seven:
> 
>        jdk.module.addmods
>        jdk.module.limitmods
>        jdk.module.addexports
>        jdk.module.addreads
>        jdk.module.patch
>        jdk.module.path
>        jdk.module.upgrade.path
> 
> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8162412
> 
> Open webrev: http://cr.openjdk.java.net/~hseigel/bug_8162412/
> 
> The fix was tested with the JCK Lang and VM tests, the hotpot, and java/lang, java/util and other JTreg tests, and the NSK non-colocated quick tests.
> 
> Thanks, Harold