RFR: 8157133: CompactHashtableWriter SIGFPE when num bucket is zero

Dmitry Samersoff dmitry.samersoff at oracle.com
Wed Jun 15 13:26:22 UTC 2016


Robbin,

It might be better to refactor the code a bit, to avoid unnecessary
division:

int number_of_entrises = the_table()->number_of_entries();
int num_buckets =
        (number_of_entries > SharedSymbolTableBucketSize) ?
        number_of_entries/SharedSymbolTableBucketSize : 1;

-Dmitry

On 2016-05-17 16:43, Robbin Ehn wrote:
> Hi all,
> 
> Please review!
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8157133
> Webrev: http://cr.openjdk.java.net/~rehn/8157133/webrev/
> 
> Tested with hotspot_jprt and
> hotspot/test/runtime/CommandLine/OptionsValidation/
> 
> Thanks!
> 
> /Robbin


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.


More information about the hotspot-runtime-dev mailing list