RFR: 8157133: CompactHashtableWriter SIGFPE when num bucket is zero

[Robbin Ehn]

Hi Dmitry,

There is a bug for this calculation:

https://bugs.openjdk.java.net/browse/JDK-8157557

Please comment your concerns there.

/Robbin


On 06/15/2016 03:26 PM, Dmitry Samersoff wrote:
> Robbin,
>
> It might be better to refactor the code a bit, to avoid unnecessary
> division:
>
> int number_of_entrises = the_table()->number_of_entries();
> int num_buckets =
>          (number_of_entries > SharedSymbolTableBucketSize) ?
>          number_of_entries/SharedSymbolTableBucketSize : 1;
>
> -Dmitry
>
> On 2016-05-17 16:43, Robbin Ehn wrote:
>> Hi all,
>>
>> Please review!
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8157133
>> Webrev: http://cr.openjdk.java.net/~rehn/8157133/webrev/
>>
>> Tested with hotspot_jprt and
>> hotspot/test/runtime/CommandLine/OptionsValidation/
>>
>> Thanks!
>>
>> /Robbin
>