RFR(XS): 8151805 - fatal error: heap walk aborted with error 1

[Christian Tornqvist]

Hi everyone,

 

Please review this small change that fixes an issue when we're trying to
validate the native heap on Windows with page heap enabled. When trying to
walk the heap with page heap enabled, the call to HeapWalk fails with
ERROR_INVALID_FUNCTION. 

 

The fix is to check the return value and also make sure it's the first call
to HeapWalk that failed, in this case phe.lpData will still be NULL.

 

Testing done:

* Ran java -version with page heap enabled/disabled on a fastdebug build

* Verified that we still catch and report a corrupted native heap by
manually overwriting some native memory allocations before the heap
validation code was called.

 

Webrev:

http://cr.openjdk.java.net/~ctornqvi/webrev/8151805/webrev.00/

 

Bug:

https://bugs.openjdk.java.net/browse/JDK-8151805

 

Thanks,

Christian