RFR(XS): 8151805 - fatal error: heap walk aborted with error 1

[George Triantafillou]

+1

-George

On 5/4/2016 10:40 AM, Daniel D. Daugherty wrote:
> > http://cr.openjdk.java.net/~ctornqvi/webrev/8151805/webrev.00/
>
> src/os/windows/vm/os_windows.cpp
>
>     L5257:       if (err != ERROR_NO_MORE_ITEMS && err != 
> ERROR_CALL_NOT_IMPLEMENTED &&
>     L5258:          (err == ERROR_INVALID_FUNCTION && phe.lpData != 
> NULL)) {
>
>         nit: Should be one more space before '(err =='.
>
> Thumbs up. Only a nit so your choice to fix or ignore and I
>
> don't need to see another webrev in either case.
>
>
> Dan
>
>
> On 5/4/16 8:22 AM, Christian Tornqvist wrote:
>> Hi everyone,
>>
>>
>> Please review this small change that fixes an issue when we're trying to
>> validate the native heap on Windows with page heap enabled. When 
>> trying to
>> walk the heap with page heap enabled, the call to HeapWalk fails with
>> ERROR_INVALID_FUNCTION.
>>
>>
>> The fix is to check the return value and also make sure it's the 
>> first call
>> to HeapWalk that failed, in this case phe.lpData will still be NULL.
>>
>>
>> Testing done:
>>
>> * Ran java -version with page heap enabled/disabled on a fastdebug build
>>
>> * Verified that we still catch and report a corrupted native heap by
>> manually overwriting some native memory allocations before the heap
>> validation code was called.
>>
>>
>> Webrev:
>>
>> http://cr.openjdk.java.net/~ctornqvi/webrev/8151805/webrev.00/
>>
>>
>> Bug:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8151805
>>
>>
>> Thanks,
>>
>> Christian
>>
>