RFR(S): 8156992: [ppc] Implement template interpreter stack overflow checks as on x86/sparc.

dean.long at oracle.com dean.long at oracle.com
Thu May 19 00:15:11 UTC 2016


By changing the value of the _stack_overflow_limit field, does the 
following x86/sparc comment
still make sense?

// TODO: rather than touching all pages, check against 
stack_overflow_limit and bang yellow page to
// generate exception

Also, I have to admit that I don't understand why we use different 
values for stack checks/bang in different places, especially the using 
MAX2 instead of +.  Can anyone explain this?  The + makes sense to me, 
but the MAX2 does not.

dl

On 5/18/16 3:02 AM, Lindenmaier, Goetz wrote:
> Hi,
>
>
>
> When porting the template interpreter, we implemented a different approach to
>
> Stack overflow handling.  See also the detailed description in the Jira bug.
>
>
>
> This change implements the stack overflow check as on x86/sparc.
>
> It requires simple shared changes, but only to code only used on ppc.
>
> The changes should not affect the other platforms.
>
>
>
> Please review this change. I please need a sponsor.
>
> http://cr.openjdk.java.net/~goetz/wr16/8156922-ppcStackFix/webrev.01/
>
>
>
> Best regards,
>
>    Goetz.
>



More information about the hotspot-runtime-dev mailing list