RFR (M): 8145148: InterfaceMethod CP entry pointing to a class should cause ICCE

[Coleen Phillimore]

Serguei,
Thank you for reviewing!  I updated the test to have PASSED - expected 
ICCE thrown and FAILED - ICCE should be thrown.

Coleen

On 5/17/16 4:18 PM, serguei.spitsyn at oracle.com wrote:
> Hi Coleen,
>
> It looks like a great fix to me.
> Just a couple of test related nits.
>
> test/runtime/ConstantPool/BadMethodHandles.java
>
>   The lines that print some diagnostic messages can be more helpful 
> with some details:
>   213                 System.out.println("FAILED (no exception)"); // ICCE should be thrown
>   236                 System.out.println("FAILED (no exception)"); // ICCE should be thrown  Failed because an ICCE was expected to be thrown.
>
>   217                     System.out.println("PASSED");
>   240                     System.out.println("PASSED");  Passed because an expected ICCE exception was thrown.
>
>   221                     System.out.println("FAILED with exception");
>   244                     System.out.println("FAILED with exception");  Failed because an unexpected exception <name> was thrown.
>
> Similar nits for the test:   test/runtime/ConstantPool/IntfMethod.java 
> Thanks, Serguei On 5/16/16 18:10, Coleen Phillimore wrote:
>> Summary: pass tag in LinkInfo and check that resolved method type 
>> matches tag, fix tests. Yumin's initial checkin of this code caused 
>> many test failures. These have been addressed in this change and in 
>> previous changes to the internal testbase tests.  The ASM change to 
>> enable passing boolean for interface methods to the Handle 
>> constructor was checked in some time ago.  This has been tested with 
>> our full nightly set. open webrev at 
>> http://cr.openjdk.java.net/~coleenp/8145148.01/webrev bug link 
>> https://bugs.openjdk.java.net/browse/JDK-8145148 Thanks, Coleen