RFR (XS): 8074085: os::get_native_stack() could use some cleanup

[Всеволод Толстопятов]

Hi,
Thank you, but as CR states, this check is not really needed: sender_pc
will become get_sender_for_C_frame(fr).pc() on very next iteration and
check in "while (fr.pc() && ...)" will fail as expected

--
Best regards,
Tolstopyatov Vsevolod

On Tue, May 31, 2016 at 1:01 PM, David Holmes <david.holmes at oracle.com>
wrote:

> Hi,
>
> On 31/05/2016 7:40 PM, Всеволод Толстопятов wrote:
>
>> Hi,
>> Could you please review and sponsor simple cleanup for
>> os::get_native_stack() in os_posix.cpp?
>>
>> CR: *https://bugs.openjdk.java.net/browse/JDK-8074085
>> <https://bugs.openjdk.java.net/browse/JDK-8074085>*
>> Webrev: *
>> http://cr.openjdk.java.net/~fzhinkin/vtolstopyatov/8074085/webrev.00/
>> <http://cr.openjdk.java.net/~fzhinkin/vtolstopyatov/8074085/webrev.00/>*
>> Testing: hotspot_runtime tests, except jasm and jcoder ones
>>
>
> You seem to have lost the check for fr.sender_pc() == NULL.
>
> David
>
>
> --
>> Best regards,
>> Tolstopyatov Vsevolod
>>
>>