RFR (XS): 8074085: os::get_native_stack() could use some cleanup

[Всеволод Толстопятов]

Does it mean it can't even go to dev branch?

I'm not (should it be stated explicitly in mail as long as it's in CR?),
I'm not even an openjdk author (webrev is hosted by my colleague as you can
see), that's why I'm trying to send simple patches to get into contribution
process first, sorry if this RFR confused you.

--
Best regards,
Tolstopyatov Vsevolod

On Tue, May 31, 2016 at 1:11 PM, David Holmes <david.holmes at oracle.com>
wrote:

> On 31/05/2016 8:01 PM, David Holmes wrote:
>
>> Hi,
>>
>> On 31/05/2016 7:40 PM, Всеволод Толстопятов wrote:
>>
>>> Hi,
>>> Could you please review and sponsor simple cleanup for
>>> os::get_native_stack() in os_posix.cpp?
>>>
>>> CR: *https://bugs.openjdk.java.net/browse/JDK-8074085
>>> <https://bugs.openjdk.java.net/browse/JDK-8074085>*
>>> Webrev:
>>> *http://cr.openjdk.java.net/~fzhinkin/vtolstopyatov/8074085/webrev.00/
>>> <http://cr.openjdk.java.net/~fzhinkin/vtolstopyatov/8074085/webrev.00/>*
>>> Testing: hotspot_runtime tests, except jasm and jcoder ones
>>>
>>
>> You seem to have lost the check for fr.sender_pc() == NULL.
>>
>
> Sorry just read the bug report.
>
> Unfortunately as we are past feature complete this enhancement can't go in
> without going through the yet-to-be-defined approval process.
>
> Also I'm a little unclear how to handle this submission as you can't
> really claim to be the contributor when the code change is listed in the
> bug report. ??
>
> Cheers,
> David
>
>
>
> David
>>
>> --
>>> Best regards,
>>> Tolstopyatov Vsevolod
>>>
>>>