RFR(S): 8160064: StackWalker implementation added logging option without using UL
Max Ockner
max.ockner at oracle.com
Tue Sep 27 20:44:05 UTC 2016
Hi Rachel,
This test is set to run only on 64 bit platforms, but I don't think we
should have that restriction.
In /test/runtime/LocalLong/StackwalkLoggingTest.java:
53 if (Platform.is64bit()) {
^^ This line shouldn't be there.
I also noticed that all of the logging is set to trace level. Was this intentional?
Otherwise, this looks good to me.
Thanks,
Max
On 9/27/2016 3:47 PM, Rachel Protacio wrote:
> Hi,
>
> Please review this small fix correcting the StackWalker print output
> mechanism by moving it to Unified Logging. Includes a new jtreg test,
> and passes JPRT.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8160064
> Open webrev: http://cr.openjdk.java.net/~rprotacio/8160064/
>
> Thank you!
> Rachel
More information about the hotspot-runtime-dev
mailing list