RFR(S): 8160064: StackWalker implementation added logging option without using UL

[Rachel Protacio]

Hi, Max,

Thanks for the review! I actually tried running the test without the 
64-bit check, but the program fails on 32-bit platforms (e.g. 
http://scaaa637.us.oracle.com/archive/2016/09/2016-09-27-185004.rprotaci.8166064/logs/linux_i586_3.8-fastdebug-c2-hotspot_fast_runtime.log.FAILED.log) 
so I left in the check. If we care about explicitly testing the logging 
on 32-bit platforms as well I could write a different test. I just 
didn't think it was necessary. What do you think?

Will address the trace level logging at the tip of that ongoing thread.

Rachel

On 9/27/2016 4:44 PM, Max Ockner wrote:
> Hi Rachel,
>
> This test is set to run only on 64 bit platforms, but I don't think we 
> should have that restriction.
>
> In /test/runtime/LocalLong/StackwalkLoggingTest.java:
>
> 53         if (Platform.is64bit()) {
>
> ^^ This line shouldn't be there.
>
>
> I also noticed that all of the logging is set to trace level. Was this 
> intentional?
>
> Otherwise, this looks good to me.
>
> Thanks,
> Max
>
>
>
> On 9/27/2016 3:47 PM, Rachel Protacio wrote:
>> Hi,
>>
>> Please review this small fix correcting the StackWalker print output 
>> mechanism by moving it to Unified Logging. Includes a new jtreg test, 
>> and passes JPRT.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8160064
>> Open webrev: http://cr.openjdk.java.net/~rprotacio/8160064/
>>
>> Thank you!
>> Rachel
>