RFR: 8185746: Remove Mutex destructor assertion

Kim Barrett kim.barrett at oracle.com
Thu Aug 3 17:44:48 UTC 2017


> On Aug 3, 2017, at 8:11 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
> 
> Hi,
> 
> On Wed, 2017-08-02 at 19:31 -0400, Kim Barrett wrote:
>>> 
>>> On Aug 2, 2017, at 7:23 PM, David Holmes <david.holmes at oracle.com>
>>> wrote:
>>> 
>>> Hi Kim,
>>> 
>>> On 3/08/2017 8:41 AM, Kim Barrett wrote:
>>>> 
>>>> Please review this small change to improve the debugging
>>>> experience
> 
> Looks good.

Thanks.

>>>> when a mutex is destroyed in a bad state.
>>>> I've removed the assert in ~Mutex, which was making the same
>>>> checks as
>>>> in ~Monitor, but providing much less information.
>>> Okay. Please can you add a comment to the ~Mutex noting that eg:
>>> 
>>> // Defer any state checking to ~Monitor
>>> Mutex::~Mutex() { }
>> Well, I was waffling over just removing it completely.
>> 
> 
>   do it :) I can't see, apart from it being a bug (to be fixed in
> another CR?), why the constructor of Monitor is not virtual.

It’s gone now.




More information about the hotspot-runtime-dev mailing list