RFR: 8185746: Remove Mutex destructor assertion

Thomas Schatzl thomas.schatzl at oracle.com
Mon Aug 7 09:55:05 UTC 2017


Hi,

On Thu, 2017-08-03 at 13:44 -0400, Kim Barrett wrote:
> > 
> > On Aug 3, 2017, at 8:11 AM, Thomas Schatzl <thomas.schatzl at oracle.c
> > om> wrote:
> > 
> > On Wed, 2017-08-02 at 19:31 -0400, Kim Barrett wrote:
> > > 
> > > > 
> > > > On Aug 2, 2017, at 7:23 PM, David Holmes <david.holmes at oracle.c
> > > > om>
> > > > wrote:
> > > > 
> > > > Hi Kim,
> > > > 
> > > > On 3/08/2017 8:41 AM, Kim Barrett wrote:
> > > > > 
> > > > > 
> > > > > Please review this small change to improve the debugging
> > > > > experience
> > Looks good.
> Thanks.
> 
> > > > [...]
> > > > // Defer any state checking to ~Monitor
> > > > Mutex::~Mutex() { }
> > > Well, I was waffling over just removing it completely.
> > > 
> >   do it :) I can't see, apart from it being a bug (to be fixed in
> > another CR?), why the constructor of Monitor is not virtual.
> It’s gone now.
> 

  still looks good.

Thomas



More information about the hotspot-runtime-dev mailing list