RFR(XXS) 8186748: NMT: memTracker::record_virtual_memory_reserve_and_commit() does not tag the memory as committed

Zhengyu Gu zgu at redhat.com
Thu Aug 24 19:04:57 UTC 2017


On 08/24/2017 02:50 PM, coleen.phillimore at oracle.com wrote:
> 
> This looks good.  I assume that you ran the NMT tests on it.  I'll 
> sponsor it.
> Coleen

Yes, I ran jtreg NMT tests.

Thanks so much for the review and sponsorship, again!

-Zhengyu


> 
> 
> On 8/24/17 2:29 PM, Zhengyu Gu wrote:
>> Please review this one line change to fix missing tag of committed 
>> memory region.
>>
>> The bug results NMT to report "Shared class space" as reserved, but 
>> not committed region.
>>
>>
>> bug:    https://bugs.openjdk.java.net/browse/JDK-8186748
>> Webrev: http://cr.openjdk.java.net/~zgu/8186748/webrev.00/
>>
>>
>>
>> Before:
>>
>> - Shared class space (reserved=16904KB, committed=0KB)
>>                             (mmap: reserved=16904KB, committed=0KB)
>>
>> After:
>>
>> -        Shared class space (reserved=16832KB, committed=16832KB)
>>                             (mmap: reserved=16832KB, committed=16832KB)
>>
>>
>> Thanks,
>>
>> -Zhengyu
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 8186748.patch
Type: text/x-patch
Size: 1246 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20170824/ffa199ce/8186748.patch>


More information about the hotspot-runtime-dev mailing list