RFR JDK-8152206: Simplify jvmstat modules

George Triantafillou george.triantafillou at oracle.com
Wed Jan 18 21:27:26 UTC 2017


Hi Mandy,

Thanks for the review.

On 1/18/2017 2:04 PM, Mandy Chung wrote:
> The change looks fine.
>
> Do you know where the dependency on sun.jvmstat.monitor.* gets pulled in?  I did a grep “sun.jvmstat.monitor” on <top>/test and hotspot/test and can’t explain why test depends on it.

Harold said that he deleted "@modules jdk.jvmstat/sun.jvmstat.monitor" 
from a couple of the hotspot/runtime tests, re-ran them, and they passed.

We can open a new bug to investigate which tests actually need "@modules 
sun.jvmstat.monitor ".

-George

>
> Mandy
>
>> On Jan 18, 2017, at 10:45 AM, George Triantafillou <george.triantafillou at oracle.com> wrote:
>>
>> Please review this fix for JDK-8152206.  The module jdk.jvmstat.rmi was renamed to jdk.jstatd.  All tests and makefiles were updated with the new module name.
>>
>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8152206
>> Open Webrevs:
>>
>> http://cr.openjdk.java.net/~gtriantafill/8152206/webrev/top/webrev/ <http://cr.openjdk.java.net/%7Egtriantafill/8152206/webrev/top/webrev/>
>> http://cr.openjdk.java.net/~gtriantafill/8152206/webrev/jdk/webrev/ <http://cr.openjdk.java.net/%7Egtriantafill/8152206/webrev/jdk/webrev/>
>> http://cr.openjdk.java.net/~gtriantafill/8152206/webrev/hotspot/webrev/ <http://cr.openjdk.java.net/%7Egtriantafill/8152206/webrev/hotspot/webrev/>
>>
>> The fix was tested with the hotspot_all test group on Linux x64. Thanks.
>>
>> -George
>>



More information about the hotspot-runtime-dev mailing list