RFR JDK-8152206: Simplify jvmstat modules

Mandy Chung mandy.chung at oracle.com
Wed Jan 18 21:52:04 UTC 2017


> On Jan 18, 2017, at 1:27 PM, George Triantafillou <george.triantafillou at oracle.com> wrote:
> 
> Hi Mandy,
> 
> Thanks for the review.
> 
> On 1/18/2017 2:04 PM, Mandy Chung wrote:
>> The change looks fine.
>> 
>> Do you know where the dependency on sun.jvmstat.monitor.* gets pulled in?  I did a grep “sun.jvmstat.monitor” on <top>/test and hotspot/test and can’t explain why test depends on it.
> 
> Harold said that he deleted "@modules jdk.jvmstat/sun.jvmstat.monitor" from a couple of the hotspot/runtime tests, re-ran them, and they passed.
> 

I guess it might come from the dependency from some test library that was probably updated and no longer have such dependency.

> We can open a new bug to investigate which tests actually need "@modules sun.jvmstat.monitor ".

Yes please file a bug.  It’d be good to clean up @modules.  You may want to check with Shura on his tool that detects if any test @modules needs update which is useful when looking into it.

Mandy


More information about the hotspot-runtime-dev mailing list