RFR(S): 8185694: Replace SystemDictionaryShared::_java_platform_loader with SystemDictionary::is_platform_class_loader()

[mandy chung]

On 10/4/17 10:12 AM, Calvin Cheung wrote:
> Mandy, David,
>
> Thanks for the review.
>
> I've made the change based on your suggestion:
> http://cr.openjdk.java.net/~ccheung/8185694/webrev.01/
systemDictionary.cpp

SystemDictionary::roots_oops_do and oops_do have to be updated to 
traverse during GC.  Is this new java_platform_loader function used 
anywhere?

Currently 
SystemDictionary::jdk_internal_loader_ClassLoaders_PlatformClassLoader_klass 
is preloaded.  Shouldn't this be removed?  What about 
jdk_internal_loader_ClassLoaders_AppClassLoader?

thread.cpp

3752 SystemDictionary::compute_java_loaders(CHECK_(JNI_ERR));

What is the difference between CHECK_(JNI_ERR) vs CHECK_JNI_ERR?  Should 
it simply use CHECK_JNI_ERR as in other places?

Mandy