RFR(S): JDK-8203481 Incorrect constraint for unextended_sp in frame:safe_for_sender

[Daniel D. Daugherty]

On 6/10/18 12:54 PM, Dmitry Samersoff wrote:
> Hello Everybody,
>
> Please, review updated webrev:
>
> http://cr.openjdk.java.net/~dsamersoff/JDK-8203481/webrev.02

This is still very confusing. In one part of this thread, we're talking
like this is ARM only fix because X64 does things differently. In another
part of this thread, we're talking like this bug affects all platforms,
but I haven't seen failures on X64 due to this so...  Something is still
not making sense here.


The patch itself is inconsistent between platforms. Here's the key
logic line in all four platforms:

+  bool unextended_sp_safe = (unextended_sp < thread->stack_base());
+                             (unextended_sp <= thread->stack_base()));
+  bool unextended_sp_safe = (_UNEXTENDED_SP <= thread->stack_base());
+  bool unextended_sp_safe = (unextended_sp < thread->stack_base());

Two platforms use '<' and two use '<='.


Dan


>
> CR link:
>
> https://bugs.openjdk.java.net/browse/JDK-8203481
>
> -Dmitry
>
> On 05/21/2018 04:44 PM, Dmitry Samersoff wrote:
>> Hello Everybody,
>>
>> Please review small fix
>>
>> http://cr.openjdk.java.net/~dsamersoff/JDK-8203481/webrev.01/
>>
>> CR:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8203481
>>
>> Testing:
>>
>> jfr tests that depends to safe_for_sender functionality
>>
>> ./jdk/jdk/jfr/api/consumer/TestRecordedFullStackTrace.java
>> ./jdk/jdk/jfr/event/profiling/TestFullStackTrace.java
>>
>> fails on AARCH64.
>>
>> These tests passed after the fix.
>>
>>
>