RFR(S): JDK-8203481 Incorrect constraint for unextended_sp in frame:safe_for_sender

Daniel D. Daugherty daniel.daugherty at oracle.com
Thu Jun 14 20:50:15 UTC 2018


On 6/10/18 5:05 PM, David Holmes wrote:
> Hi Dmitry,
>
> I have to admit I still can't connect all the pieces here. When we are 
> operating in frame::safe_for_sender, what has set _unextended_sp? Can 
> you walk through a complete example? I can't quite connect Andrew's 
> example to the original problem.
>
> It still seems to me that the current frame should have:
>
> sp <= unextended_sp <= stack_base()

David, you and I are in agreement here. At least I'm in agreement
for X64 (and SPARC).

Dan


>
> ??
>
> Thanks,
> David
>
> On 11/06/2018 2:54 AM, Dmitry Samersoff wrote:
>> Hello Everybody,
>>
>> Please, review updated webrev:
>>
>> http://cr.openjdk.java.net/~dsamersoff/JDK-8203481/webrev.02
>>
>> CR link:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8203481
>>
>> -Dmitry
>>
>> On 05/21/2018 04:44 PM, Dmitry Samersoff wrote:
>>> Hello Everybody,
>>>
>>> Please review small fix
>>>
>>> http://cr.openjdk.java.net/~dsamersoff/JDK-8203481/webrev.01/
>>>
>>> CR:
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8203481
>>>
>>> Testing:
>>>
>>> jfr tests that depends to safe_for_sender functionality
>>>
>>> ./jdk/jdk/jfr/api/consumer/TestRecordedFullStackTrace.java
>>> ./jdk/jdk/jfr/event/profiling/TestFullStackTrace.java
>>>
>>> fails on AARCH64.
>>>
>>> These tests passed after the fix.
>>>
>>>
>>
>>
>



More information about the hotspot-runtime-dev mailing list