RFR: JDK-8199781: Don't use naked == for comparing oops
coleen.phillimore at oracle.com
coleen.phillimore at oracle.com
Thu Mar 29 12:49:40 UTC 2018
On 3/29/18 8:02 AM, Roman Kennke wrote:
> Am 29.03.2018 um 13:29 schrieb Andrew Haley:
>> On 03/29/2018 10:14 AM, Roman Kennke wrote:
>>> I wouldn't necessarily trust the compiler to do the expected thing. It
>>> wouldn't be the first time that I see a compiler not inline something
>>> because it's blown some complexity limit.
>>>
>>> Do you want to push the final patch (pending reviews)? Or should I do it?
>>>
>>> Also, it would be nice to get ok from John and Andrew. :-)
>> Thanks for getting it (probably) to inline. We need to make sure
>> that our "improvements" don't cause subtle regressions, as John
>> says.
> Coleen offered to run Oracle-internal performance test suite with the
> patch. Coleen: now would be a good time to do that, if you can. ?
Yes, I can run it. I ran your .02 change and there weren't any
significant differences according to the suite we run. I've fired off
a new one.
thanks,
Coleen
>
> Thanks, Roman
>
More information about the hotspot-runtime-dev
mailing list