RFR: JDK-8199781: Don't use naked == for comparing oops

John Rose john.r.rose at oracle.com
Thu Mar 29 19:33:24 UTC 2018


On Mar 29, 2018, at 4:29 AM, Andrew Haley <aph at redhat.com> wrote:
> 
> On 03/29/2018 10:14 AM, Roman Kennke wrote:
>> I wouldn't necessarily trust the compiler to do the expected thing. It
>> wouldn't be the first time that I see a compiler not inline something
>> because it's blown some complexity limit.
>> 
>> Do you want to push the final patch (pending reviews)? Or should I do it?
>> 
>> Also, it would be nice to get ok from John and Andrew. :-)
> 
> Thanks for getting it (probably) to inline.  We need to make sure
> that our "improvements" don't cause subtle regressions, as John
> says.

+1, thanks all.

Now we need to comment up the access API so it is more maintainable.
But Roman doesn't need to wait on that.



More information about the hotspot-runtime-dev mailing list