RFR (S) 8198717: Remove compute_optional_offset

[coleen.phillimore at oracle.com]

On 9/19/18 9:51 AM, Claes Redestad wrote:
> Nice cleanup!
>
> I think setting these previously optional offsets to -1 in the 
> compute_offset methods is now pointless. I suggest removing that along 
> with the legacy comments (".. only present in 1.5") and related asserts.

Yeah, you're right. I don't need this.  The vm will not start if these 
fields are not found.  Thank you for reviewing this!

http://cr.openjdk.java.net/~coleenp/8198717.02/webrev

Sorry not incremental.  Retesting in progress.

thanks!
Coleen

>
> /Claes
>
> On 2018-09-19 01:28, coleen.phillimore at oracle.com wrote:
>> Summary: remove optional_offset computation and related unused code 
>> from javaClasses for reflection.
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/8198717.01/webrev
>> bug link https://bugs.openjdk.java.net/browse/JDK-8198717
>>
>> Tested with hs-tier1 and 2.
>>
>> Thanks,
>> Coleen
>