RFR (XS) 8221918: runtime/SharedArchiveFile/serviceability/ReplaceCriticalClasses.java fails: Shared archive not found

[David Holmes]

Hi Aleksey,

There's no error checking in the dump part - if something goes wrong we 
won't see anything to indicate what it was, and AFAICS we won't even 
notice the failure (till the second part of the test).

Aside: not sure why we can't just use:

@run main/othervm -XX:SharedArchiveFile=... -Xshare:dump

and let jtreg deal with error?

Please update copyright to "2018, 2019,"

Thanks,
David

On 4/04/2019 3:45 am, Aleksey Shipilev wrote:
> On 4/3/19 7:37 PM, Jiangli Zhou wrote:
>> Looks like we were going to the same direction. I sent out the review before seeing your second
>> version. This looks okay to me.
> 
> Yes! Thanks for review.
> 
> I have not noticed there CDSTestUtils.createArchive, I guess explicit setArchiveName is as good.
> I'll wait for jdk-submit to clear webrev.02 for me and wait for another review maybe.
> 
> -Aleksey
> 
>>      New webrev:
>>        http://cr.openjdk.java.net/~shade/8221918/webrev.02/
>