RFR(xs): 8183004: Remove code related to gtest death tests from assert macro

[Igor Ignatyev]

Hi Thomas,

 "assert failed: " was added so we will know for sure that ASSERT_EXIT matches the message from the JVM assert, and not just some random string printed by JVM. So I'd prefer we not just restore "assert failed: " (or replace it w/ another string) but also harden the assertion by adding ^ in front of this prefix.

-- Igor  

> On Feb 12, 2019, at 1:18 PM, Thomas Stüfe <thomas.stuefe at gmail.com> wrote:
> 
> On Tue, Feb 12, 2019 at 10:09 PM Aleksey Shipilev <shade at redhat.com> wrote:
> 
>> On 2/12/19 9:58 PM, Thomas Stüfe wrote:
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8183004
>>> cr:
>>> 
>> http://cr.openjdk.java.net/~stuefe/webrevs/8183004--remove-code-related-to-gtest-death-tests-from-assert-macro/webrev.00/webrev/
>> 
>> I like it. I like smaller binaries a lot too.
>> 
>> Was the prefix string "assert failed: " meaningful? Is there a reason to
>> remove it?
>> 
>> 
> Hmm, none really, apart from that is was not really needed to make the test
> work. I can re-add it if you prefer.
> 
> ..Thomas
> 
> 
>> -Aleksey
>> 
>>