RFR: 8217921: Runtime dead code removal

[David Holmes]

Hi Claes,

On 29/01/2019 7:24 am, Claes Redestad wrote:
> Hi,
> 
> please review this patch to remove dead code in the runtime, interpreter
> and related areas.
> 
> Bug:    https://bugs.openjdk.java.net/browse/JDK-8217921
> Webrev: http://cr.openjdk.java.net/~redestad/8217921/open.00/

This mostly seems okay but I have some reservations about trimming APIs 
just because we don't currently use them. For example the changes in

src/hotspot/share/memory/binaryTreeDictionary.inline.hpp

I expect to see a complete data structures defined with all the 
reasonable operations. The fact we don't actually use some of them 
doesn't mean to me that we should cull them out of the API.

Cheers,
David
-----

> Testing: tier1+2
> 
> I've taken care to check every change to ensure it's not in use by some
> platform specific code on a platform that's not built/supported by
> Oracle, but help verifying this would be greatly appreciated.
> 
> I've also checked the patch applies cleanly to a few valhalla and amber
> branches to avoid excessive merge issues.
> 
> Thanks!
> 
> /Claes