RFR: 8217921: Runtime dead code removal

Claes Redestad claes.redestad at oracle.com
Tue Jan 29 09:50:58 UTC 2019


On 2019-01-29 10:30, David Holmes wrote:
>>
>> Webrev: http://cr.openjdk.java.net/~redestad/8217921/open.00/
> 
> This mostly seems okay but I have some reservations about trimming APIs 
> just because we don't currently use them. For example the changes in
> 
> src/hotspot/share/memory/binaryTreeDictionary.inline.hpp
> 
> I expect to see a complete data structures defined with all the 
> reasonable operations. The fact we don't actually use some of them 
> doesn't mean to me that we should cull them out of the API.

I disagree: It's easy to add functionality back if/when we need it, and
unused/untested code should be considered broken until proven otherwise.

/Claes


More information about the hotspot-runtime-dev mailing list