RFR: 8225035: Thread stack size issue caused by large TLS size

[Jiangli Zhou]

Hi Roger,

On Mon, Jul 8, 2019 at 7:56 AM Roger Riggs <Roger.Riggs at oracle.com> wrote:
>
> Hi,
>
> src/hotspot/os/linux/os_linux.cpp:
>
> 849: typo in comment: "allocats" ->  "allocates"

Fixed in place. Thanks!

>
>
>
> Will there be a release note describing the behavior and possibly the
> relation to the
> system property "jdk.lang.processReaperUseDefaultStackSize" added by
> 8086278  [1].

A release note sounds like a good idea. The
"jdk.lang.processReaperUseDefaultStackSize" system property seems no
longer necessary with this more-general workaround, but that can be
made as separate decision. Thoughts?

>
> If so, add a label release-note=yes to the issue and create a subtask
> with for the "Release Note:.....".

Will do. The TLS issue and the new AdjustStackSizeForTLS option are
Linux only, any additional process regarding the release note?

Best regards,
Jiangli
>
> Thanks, Roger
>
>
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8086278
>
> On 7/8/19 10:27 AM, Jiangli Zhou wrote:
> > Hi Florian,
> >
> > Here is the full webrev:
> > http://cr.openjdk.java.net/~jiangli/8225035/webrev.05/, including the
> > additional comments above get_static_tls_area_size.
> >
> > Best regards,
> > Jiangli
> >
> > On Mon, Jul 8, 2019 at 2:27 AM Florian Weimer <fweimer at redhat.com> wrote:
> >> * Jiangli Zhou:
> >>
> >>> As you, Florian, Thomas all made great contributions to this
> >>> workaround, I should list all of you as both contributors and
> >>> reviewers in the changeset. If there is any objection, please let me
> >>> know.
> >> Can you share a link with the final patch?  I would like to have another
> >> look.
> >>
> >> Thanks,
> >> Florian
>