RFR (S) 8221325: Add information about swap space to print_memory_info() on MacOS

David Holmes david.holmes at oracle.com
Tue Mar 26 12:11:24 UTC 2019


Hi Ralf,

On 26/03/2019 7:01 pm, Schmelter, Ralf wrote:
> Hi David,
> 
>> Is offsetof coming from the compiler? Should it be hotspot's offset_of instead?
> 
> offsetof would come from <stddef.h> normally, but here offsetof is offset_of. It is redefined in global_definitions_gcc.hpp.

I'm never sure which compiler files are used on BSD or Mac OS. :)

> I've changed to offset_of: http://cr.openjdk.java.net/~rschmelter/webrevs/8221325/webrev.2/

Thanks. Seems fine.

David

> Best regards,
> Ralf
> 


More information about the hotspot-runtime-dev mailing list