RFR: JDK-8223599: minimal build failed after JDK-8185525

[Stefan Karlsson]

On 2019-05-09 20:06, Ao Qi wrote:
> On Fri, May 10, 2019 at 12:56 AM Aleksey Shipilev <shade at redhat.com> wrote:
>> On 5/9/19 4:12 PM, Ao Qi wrote:
>>> On Thu, May 9, 2019 at 9:43 PM David Holmes <david.holmes at oracle.com> wrote:
>>>> On 9/05/2019 9:12 pm, Wang Haomin wrote:
>>>>> Hi  Aleksey, David,
>>>>>
>>>>> Thanks for your suggestion. However, build is failed when using
>>>>> "--with-jvm-features=-jfr --with-jvm-variants=server
>>>>> --with-debug-level=release --disable-precompiled-headers".
>>>>> I made a litter modification. Could you review it?
>>>>>
>>>>> Webrev: http://cr.openjdk.java.net/~aoqi/8223599/webrev.02/
>>>> shenandoahCollectionSet.cpp was not altered by 8185525, so while I
>>>> understand your desire to make this fix, it doesn't seem right to do it
>>>> under the current bug as currently described. The issue with disabling
>>>> PCH would not seem to be related to the minimal build at all.
>>> Indeed. The initial desire is to fix the issue introduced by 8185525.
>>> Should I change the description or file another issue?
>> I'd say split it out. We would backport the Shenandoah issue.
> Splitted:
> http://cr.openjdk.java.net/~aoqi/8223599/webrev.03/
>
> Here is the new bug:
> https://bugs.openjdk.java.net/browse/JDK-8223651
>
> Is a new review thread needed for JDK-8223651? Webrev is here:
> http://cr.openjdk.java.net/~aoqi/8223651/webrev.00/
>
> In addition, I found it seems build with --disable-precompiled-headers
> broken again (maybe introduced by JDK-8223136) during test. I filed
> JDK-8223653 and will have a further loot at it tomorrow.

I successfully built fastdebug minimal with the patch in:
https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-May/037998.html

StefanK
>
> Thanks,
> Ao Qi
>> -Aleksey
>>