RFR(s): 8223313: Use handshakes for CountStackFrames.

David Holmes david.holmes at oracle.com
Wed May 15 12:47:55 UTC 2019


Hi Robbin,

On 15/05/2019 9:17 pm, Robbin Ehn wrote:
> Hi all please review.
> 
> This change is part of parent issue:
> Utilize handshakes instead of is_thread_fully_suspended
> https://bugs.openjdk.java.net/browse/JDK-8223312
> 
> Issue:
> https://bugs.openjdk.java.net/browse/JDK-8223313
> Change-set:
> http://cr.openjdk.java.net/~rehn/8223313/webrev/

Changes seem fine, though you could keep the comment:

// Implied else: if JavaThread is not alive simply return a count of 0.

> The only test using this seems to be CountStackFramesAtExit.java which 
> passes fine.

I would expect there to be JCK tests for this as well.

Thanks,
David
-----

> Thanks, Robbin


More information about the hotspot-runtime-dev mailing list