RFR(s): 8223313: Use handshakes for CountStackFrames.
Robbin Ehn
robbin.ehn at oracle.com
Wed May 15 13:23:35 UTC 2019
Hi David,
On 2019-05-15 14:47, David Holmes wrote:
> Hi Robbin,
>
> On 15/05/2019 9:17 pm, Robbin Ehn wrote:
>> Hi all please review.
>>
>> This change is part of parent issue:
>> Utilize handshakes instead of is_thread_fully_suspended
>> https://bugs.openjdk.java.net/browse/JDK-8223312
>>
>> Issue:
>> https://bugs.openjdk.java.net/browse/JDK-8223313
>> Change-set:
>> http://cr.openjdk.java.net/~rehn/8223313/webrev/
>
> Changes seem fine, though you could keep the comment:
>
> // Implied else: if JavaThread is not alive simply return a count of 0.
Added back!
>
>> The only test using this seems to be CountStackFramesAtExit.java which passes
>> fine.
>
> I would expect there to be JCK tests for this as well.
Ran JCK api/java_lang/Thread/CountStackFrames locally, it passes.
Thanks, Robbin
>
> Thanks,
> David
> -----
>
>> Thanks, Robbin
More information about the hotspot-runtime-dev
mailing list