RFR (T) 8251489: universe.cpp includes too many headers

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Thu Aug 13 10:02:17 UTC 2020


On 2020-08-12 18:36, Coleen Phillimore wrote:
>
>
> On 8/12/20 12:34 PM, Thomas Stüfe wrote:
>> This looks good. I wish we could do this automatically.
>
> Thanks, Thomas, I agree!
I can probably add something to the makefiles along the lines of this 
https://stackoverflow.com/a/7135530/432034. But when should it be run? 
Regularly, or just whenever someone feels there's too many headers 
again? Doing this as part of a schedule is likely to be a much harder 
problem, so for one-shot runs it's probably fairly trivial to solve.

/Magnus



> Coleen
>>
>> Thanks, Thomas
>>
>> On Wed, Aug 12, 2020 at 5:33 PM Coleen Phillimore 
>> <coleen.phillimore at oracle.com <mailto:coleen.phillimore at oracle.com>> 
>> wrote:
>>
>>     See bug for description. Tested with tier1 on 4 platforms, built 
>> with
>>     --no-precompiled-headers.
>>
>>     open webrev at
>>     http://cr.openjdk.java.net/~coleenp/2020/8251489.01/webrev
>>     bug link https://bugs.openjdk.java.net/browse/JDK-8251489
>>
>>     Thanks,
>>     Coleen
>>
>



More information about the hotspot-runtime-dev mailing list