RFR (T) 8251489: universe.cpp includes too many headers

[Coleen Phillimore]

On 8/13/20 6:02 AM, Magnus Ihse Bursie wrote:
> On 2020-08-12 18:36, Coleen Phillimore wrote:
>>
>>
>> On 8/12/20 12:34 PM, Thomas Stüfe wrote:
>>> This looks good. I wish we could do this automatically.
>>
>> Thanks, Thomas, I agree!
> I can probably add something to the makefiles along the lines of this 
> https://stackoverflow.com/a/7135530/432034. But when should it be run? 
> Regularly, or just whenever someone feels there's too many headers 
> again? Doing this as part of a schedule is likely to be a much harder 
> problem, so for one-shot runs it's probably fairly trivial to solve.
Actually, I agree in principle that it would be nice if this could be 
done automatically, but only as a one-shot thing by an individual who 
wants to clean this up.  This falls into the nice-to-do list when 
someone has time and energy for it.  I'd hate to see it permanent 
because there could be false positives as someone writes in the 
stackoverflow article and for most cpp files, the cost of the extra 
header includes is quite low.

Coleen

>
> /Magnus
>
>
>
>> Coleen
>>>
>>> Thanks, Thomas
>>>
>>> On Wed, Aug 12, 2020 at 5:33 PM Coleen Phillimore 
>>> <coleen.phillimore at oracle.com <mailto:coleen.phillimore at oracle.com>> 
>>> wrote:
>>>
>>>     See bug for description. Tested with tier1 on 4 platforms, built 
>>> with
>>>     --no-precompiled-headers.
>>>
>>>     open webrev at
>>>     http://cr.openjdk.java.net/~coleenp/2020/8251489.01/webrev
>>>     bug link https://bugs.openjdk.java.net/browse/JDK-8251489
>>>
>>>     Thanks,
>>>     Coleen
>>>
>>
>