RFR: 8165404: AArch64: Implement SHA512 accelerator/intrinsic

[Yangfei (Felix)]

CCing to the mailing lists.  Sorry for forgetting that. 


> -----Original Message-----
> From: Yangfei (Felix)
> Sent: Tuesday, August 18, 2020 2:17 PM
> To: 'Andrew Haley' <aph at redhat.com>
> Subject: RE: RFR: 8165404: AArch64: Implement SHA512 accelerator/intrinsic
> 
> Hi,
> 
> > -----Original Message-----
> > From: Andrew Haley [mailto:aph at redhat.com]
> > Sent: Monday, August 17, 2020 11:54 PM
> > To: Yangfei (Felix) <felix.yang at huawei.com>; hotspot-runtime-
> > dev at openjdk.java.net
> > Cc: aarch64-port-dev at openjdk.java.net
> > Subject: Re: RFR: 8165404: AArch64: Implement SHA512
> > accelerator/intrinsic
> >
> > On 17/08/2020 13:01, Yangfei (Felix) wrote:
> > >> Looks good. If I were editing the Python script I'd also add
> > >> random.seed(0) so that the generated code doesn't change every time.
> >
> > > Thanks for the quick reply.  Do you mean we need any more change?
> > > For the purpose for testing the instructions, it might not be a good
> > > idea to add random.seed(0).  This will limit the randomness of the
> > > register numbers used for each run.
> >
> > Not really, because we paste the output into assembler.cpp so that we
> > use the same values every time it runs. I don't think it helps anyone
> > that we use different random offsets every time the test code is
> regenerated.
> 
> Make sense to me in that respect.
> 
> I created a new issue and prepared a webrev for this:
>     Bug: https://bugs.openjdk.java.net/browse/JDK-8251885
>     Webrev: http://cr.openjdk.java.net/~fyang/8251885/webrev.01
> 
> This added random.seed(0) to aarch64-asmtest.py and regenerate the code
> as a baseline.
> Passed the smoke test for assembler in assembler_aarch64.cpp with a
> slowdebug build.
> Is it good to go?
> 
> Thanks,
> Felix