RFR: 8256008: UL does not report anything if disk writing fails [v2]

Thomas Stuefe stuefe at openjdk.java.net
Tue Dec 1 15:56:05 UTC 2020


On Tue, 1 Dec 2020 15:41:50 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Yasumasa Suenaga has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
>> 
>>  - refactoring
>>  - Merge branch 'master' into JDK-8256008
>>  - Fix typo
>>  - 8256008: UL does not report anything if disk writing fails
>
> src/hotspot/share/logging/logFileStreamOutput.cpp line 90:
> 
>> 88: };
>> 89: 
>> 90: static bool write_error_is_shown = false;
> 
> Can you make this a static member of LogFileStreamOutput please?

I also wonder whether this should not be a non-static member. Are there many streams? Isn't there one per output destination? If we stream to multiple files, we may want to see the error in each of the files.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1106


More information about the hotspot-runtime-dev mailing list