RFR: 8256008: UL does not report anything if disk writing fails [v2]
Yasumasa Suenaga
ysuenaga at openjdk.java.net
Wed Dec 2 00:43:09 UTC 2020
On Tue, 1 Dec 2020 15:45:17 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> src/hotspot/share/logging/logFileStreamOutput.cpp line 90:
>>
>>> 88: };
>>> 89:
>>> 90: static bool write_error_is_shown = false;
>>
>> Can you make this a static member of LogFileStreamOutput please?
>
> I also wonder whether this should not be a non-static member. Are there many streams? Isn't there one per output destination? If we stream to multiple files, we may want to see the error in each of the files.
Good catch! It should be a member of `LogFileStreamOutput`. I fixed it.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1106
More information about the hotspot-runtime-dev
mailing list