RFR: 8256008: UL does not report anything if disk writing fails [v2]

Yasumasa Suenaga ysuenaga at openjdk.java.net
Wed Dec 2 00:43:11 UTC 2020


On Tue, 1 Dec 2020 15:46:45 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Yasumasa Suenaga has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
>> 
>>  - refactoring
>>  - Merge branch 'master' into JDK-8256008
>>  - Fix typo
>>  - 8256008: UL does not report anything if disk writing fails
>
> src/hotspot/share/logging/logFileStreamOutput.cpp line 106:
> 
>> 104: }
>> 105: 
>> 106: #define WRITE_LOG_WITH_RESULT_CHECK(op, total)                \
> 
> You may leave out total and reference "written" directly in the macro since its always used with "written". Leave it up to you though, its a matter of taste.

I prefer that WRITE_LOG_WITH_RESULT_CHECK like a function, so I stay this change.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1106


More information about the hotspot-runtime-dev mailing list