RFR: 8257467: [TESTBUG] -Wdeprecated-declarations is reported at sigset() in exesigtest.c [v3]

[Thomas Stuefe]

On Wed, 2 Dec 2020 02:52:28 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Yasumasa Suenaga has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove -mode option from sigtest
>
> Looks good to me!
> 
> Perhaps @tstuefe could also take a look?
> 
> Thanks,
> David

Hi,

sorry for chiming in too late, I did not see this before. 

I would not remove the sigset testing from this test unless we also remove the sigset chaining capability from libjsig. Otherwise we just ship untested functionality.

So I'd say either go the full way and remove sigset() chaining from src/java.base/unix/native/libjsig/jsig.c. But that probably needs a CSR as well. Or we just go with Yasumasa's initial patch, just switching off the warning.

Cheers, Thomas

-------------

PR: https://git.openjdk.java.net/jdk/pull/1529