RFR: 8257467: [TESTBUG] -Wdeprecated-declarations is reported at sigset() in exesigtest.c [v3]

[David Holmes]

On Wed, 2 Dec 2020 06:36:17 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Looks good to me!
>> 
>> Perhaps @tstuefe could also take a look?
>> 
>> Thanks,
>> David
>
> Hi,
> 
> sorry for chiming in too late, I did not see this before. 
> 
> I would not remove the sigset testing from this test unless we also remove the sigset chaining capability from libjsig. Otherwise we just ship untested functionality.
> 
> So I'd say either go the full way and remove sigset() chaining from src/java.base/unix/native/libjsig/jsig.c. But that probably needs a CSR as well. Or we just go with Yasumasa's initial patch, just switching off the warning.
> 
> Cheers, Thomas

Hi Thomas (@tstuefe ),
Thanks for chiming in. I was ready to agree with you but something was nagging at me. Sure enough looking closer signal chaining supports three modes: sigset, sigaction and signal. But the test only tests sigset and sigaction - so we already have untested functionality. And that was because signal() use was broken and we removed it under:

https://bugs.openjdk.java.net/browse/JDK-8165192

back in 2016.

So we do have a precedence (perhaps a bad one) for removing test code without removing functional code.

But I'm okay with going back to Yasumasa's original proposal to just fix the warning and filing a RFE to deprecate, then remove sigset and signal from the signal chaining mechanism.

Thanks,
David
-----

-------------

PR: https://git.openjdk.java.net/jdk/pull/1529