RFR: 8251438: Issues with our POSIX set_signal_handler()

Thu Dec 10 20:08:00 UTC 2020

On Thu, 10 Dec 2020 07:08:13 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Hi Gerard,
> Functionally this is fine. Stylistically I would have just done simply:
> 
> return (act.sa_flags & SA_SIGINFO) != 0 ? CAST_FROM_FN_PTR(address, act.sa_sigaction) : CAST_FROM_FN_PTR(address, act.sa_handler);
> 
> Thanks,
> David

Thank you David for the review, but I need to pull it out of JDK16 and redo for JDK17. I think I need to withdraw and close it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1680