RFR: 8258438: build error in test/hotspot/gtest/runtime/test_os.cpp

[Ioi Lam]

On Tue, 15 Dec 2020 21:33:49 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Please review this trivial fix for mach5 tier1 build failure:
>> 
>> test/hotspot/gtest/runtime/test_os.cpp:525:39: error: cannot convert 'const MEMFLAGS' to 'bool'
>>      char* p = os::reserve_memory(1 * M, mtInternal);
>>                                          ^^^^^^^^^^
>> 
>> It's caused by the following change in [os.hpp](url) in [JDK-8234930](https://bugs.openjdk.java.net/browse/JDK-8234930):
>> 
>> - static char*  reserve_memory(size_t bytes, MEMFLAGS flags = mtOther);
>> + static char*  reserve_memory(size_t bytes, bool executable = false, MEMFLAGS flags = mtOther);
>> 
>> I am running a personal tier1 job to validate this fix.
>
> Marked as reviewed by tschatzl (Reviewer).

My local build passed. Since all tier1 builds had failed due to this bug, I'll integrate now. It can't make things any worse.
Thanks @dcubed-ojdk and @tschatzl  for the review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1788