RFR[T, urgent]: 8241723: Build error after 8241581

Langer, Christoph christoph.langer at sap.com
Fri Mar 27 07:43:27 UTC 2020


Hi Thomas,

looks good to me.

Best regards
Christoph

> -----Original Message-----
> From: hotspot-dev <hotspot-dev-bounces at openjdk.java.net> On Behalf Of
> Thomas Stüfe
> Sent: Freitag, 27. März 2020 08:34
> To: Hotspot dev runtime <hotspot-runtime-dev at openjdk.java.net>;
> HotSpot Open Source Developers <hotspot-dev at openjdk.java.net>
> Subject: Re: RFR[T, urgent]: 8241723: Build error after 8241581
> 
> Crosspost to hs-dev.
> 
> On Fri, Mar 27, 2020 at 8:25 AM Thomas Stüfe <thomas.stuefe at gmail.com>
> wrote:
> 
> > Hi,
> >
> > not my proudest day.
> >
> > <https://bugs.openjdk.java.net/browse/JDK-8241723>
> > Gtest for 8241581 got added accidentally after running the tests but
> > before the push. Immediate result is an escaped build error in release:
> >
> > /shared/projects/openjdk/jdk-
> jdk/source/test/hotspot/gtest/utilities/test_bitMap_popcnt.cpp:
> > In destructor 'ErrorDetailsPrinter::~ErrorDetailsPrinter()':
> > /shared/projects/openjdk/jdk-
> jdk/source/test/hotspot/gtest/utilities/test_bitMap_popcnt.cpp:96:11:
> > error: 'class BitMap' has no member named 'print_on'
> >
> > but since there may be other errors in this gtest as well, I'd like to
> > remove the test, re-run all tests, then re-add it.
> >
> > The tested functionality is still unused, so we need not to roll-back the
> > whole patch.
> >
> > https://bugs.openjdk.java.net/browse/JDK-8241723
> >
> > Fix consists of "hg
> > remove test/hotspot/gtest/utilities/test_bitMap_popcnt.cpp", so there is
> no
> > webrev.
> >
> > Thanks, Thomas
> >
> >


More information about the hotspot-runtime-dev mailing list