RFR(xs): 8245035: Clean up os::split_reserved_memory()

[coleen.phillimore at oracle.com]

Looks good to me!
Coleen

On 5/19/20 2:03 AM, Stefan Karlsson wrote:
> On 2020-05-19 06:41, Thomas Stüfe wrote:
>>
>> Hi Coleen, Stefan,
>>
>> New version: 
>> http://cr.openjdk.java.net/~stuefe/webrevs/8245035--clean-up-os--split_reserved_memory()/webrev.03/webrev/
>>
>> I deleted the dangling prototype to pd_split_reserved_memory and left 
>> everything else as it is. Still good?
>
> Yes.
>
> Thanks,
> StefanK
>
>>
>> I had not re-added it, I had just forgotten to delete it in my 
>> earlier versions :(
>>
>> Thanks, Thomas
>>
>>
>> On Mon, May 18, 2020 at 9:13 PM <coleen.phillimore at oracle.com 
>> <mailto:coleen.phillimore at oracle.com>> wrote:
>>
>>
>> http://cr.openjdk.java.net/~stuefe/webrevs/8245035--clean-up-os--split_reserved_memory()/webrev.02/webrev/src/hotspot/share/runtime/os.hpp.udiff.html
>>
>>     It looks like you added back the declaration for
>>     pd_split_reserved_memory but not the definition.
>>
>> http://cr.openjdk.java.net/~stuefe/webrevs/8245035--clean-up-os--split_reserved_memory()/webrev.02/webrev/src/hotspot/share/runtime/os.cpp.udiff.html
>>
>>     Still deleted.
>>
>>     I thought that the pd version should be removed since it simply
>>     was an empty layer.  If you want to add the asserts in os.cpp
>>     os::split_reserved_memory an reinstate the pd version to be empty
>>     for posix and release/reserve for windows, that would make sense
>>     to me.
>>
>>     I like the asserts broken up like you have them in 02.
>>
>>     Thanks,
>>     Coleen
>>
>>
>